-
Notifications
You must be signed in to change notification settings - Fork 117
chore: update how current anomaly model works with example #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @srikanthccv's task —— View job Review Complete
SummaryThis PR significantly improves the anomaly detection documentation by replacing the previous high-level overview with detailed, worked examples for each seasonality type (Hourly, Daily, Weekly). The changes are well-structured and provide valuable practical guidance. Technical Accuracy ✅The anomaly detection approach described is sound and aligns with established statistical methods:
Issues FoundI've added 7 inline comments addressing:
Strengths
RecommendationApprove after addressing the inline comments. The issues are minor formatting/clarity improvements that don't affect the technical correctness of the content. |
| Past Season 2 avg (12:05-13:05): 170ms | ||
| Past Season 3 avg (11:05-12:05): 168ms | ||
|
|
||
| Standard Deviation: 35ms - entire season |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment: "entire season" should be explained more clearly. Consider: "Standard Deviation: 35ms (calculated from the entire Current Season: 14:05-15:05)"
| 6. **Anomaly Score**: |380 - 182| / 35 = **5.66** | ||
| (5.66 > 3.0 threshold) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result formatting inconsistency: Consider adding a label before the result for clarity, like:
**Result**: ✅ Alert triggered (5.66 > 3.0 threshold)
| 6. **Anomaly Score**: |4,200 - 10,250| / 2,500 = **2.42** | ||
| #### Result | ||
| (2.42 < 3.0 threshold) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result formatting inconsistency: Consider using a consistent format like:
**Result**: ❌ No alert (2.42 < 3.0 threshold)
| Past Period (Mon 13:55-14:00): | ||
| 13:55: 7,800 txn/min # End of lunch period | ||
| 13:56: 8,100 txn/min | ||
| 13:57: 8,400 txn/min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment: "Drop on interest" should be "Drop of interest"
|
|
||
| # Very sensitive | ||
| z_score_threshold: 2.0 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline: The file should end with a newline character for POSIX compliance. Consider adding a blank line at the end.
makeavish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address claude's comments on formatting
No description provided.